atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
1.87k stars 110 forks source link

Add ff_connect_notify config option to configure.sh #447

Closed arnxxau closed 4 months ago

arnxxau commented 6 months ago

I missed this option after encountering the #444 bug, where the controller's vibration stops working. I also think it would be a good idea to set it to 'disabled' by default while the bug persists, as I find it very annoying. I'm not sure about your thoughts on this. I would fix it myself, but I wouldn't know where to start. Thanks!

codeclimate[bot] commented 6 months ago

Code Climate has analyzed commit 84397e22 and detected 0 issues on this pull request.

View more on Code Climate.

kakra commented 6 months ago

With v0.10 I'm going to change the way the notification plays. I may eventually disable it by default. I'll merge your request on the next patch round. Thanks for the contribution.