nguillaumin
commented
5 years ago This is not a light version of Jssor, it is a completely different slider. Jssor is terrible:
- The doc sucks. I wasn't able to set it up using just the docs, and I don't want to just copy/paste what we had before without understanding it
- The class names are terrible and don't follow best practices
$JssorSlider$ - Lots of stuff works with hardcoded pixels dimensions which are not compatible with the new CSS approach (use
rems rather than pixels) - The main developer is completely unhelpful and closes issues without any comments
- The unminified source code of Jssor is not available despite multiple request on their GitHub tracker, which is borderline against the MIT license they use:
- https://github.com/jssor/slider/issues/158
- https://github.com/jssor/slider/issues/224
- https://github.com/jssor/slider/issues/222
- https://github.com/jssor/slider/issues/190
- https://github.com/jssor/slider/issues/174
- https://github.com/jssor/slider/issues/171
- https://github.com/jssor/slider/issues/164
- https://github.com/jssor/slider/issues/160
- https://github.com/jssor/slider/issues/159
With all of that in mind I looked for alternative sliders. I found this LightSlider JS, but it's not as good as Jssor and I couldn't get it to work in horizontal mode (that's why the boxscans don't have a slider yet).
So I'm not sure what to do. I'm not super happy with the alternative, but I really dislike Jssor. It needs some thinking, one option could be to write our own, or keep searching for alternatives.
stgraveyard
Why exactly did we switch to a light version of the JSSOR?
While I do like the look, the new screenshot slider seems to limited. The screenshots are hard to access quickly for games with more the 5 screenshots? The scroll functionality seems limited and the responsiveness (which was a whole lot of work) is now gone. Is there a reason apart from estetics?