atari-legend / legacy

Source code for the legacy AtariLegend site (Still used for the CPANEL)
https://legacy.atarilegend.com/
GNU General Public License v3.0
3 stars 0 forks source link

Fixes #725: Improve technical details tile #735

Closed nguillaumin closed 4 years ago

nguillaumin commented 5 years ago

Make it look more like the details tile on the old game page. It's still not perfect, but I think it's better.

nguillaumin commented 5 years ago

tile-tech-details

The tile is too wide I think, but we can address that later.

stgraveyard commented 5 years ago

Hi Nico,

I appreciate it, but this is not what I like honestly, as we will have the same issues as before with the with of some text in different resolutions. I did like the first design :

image

But what I would like to do is ... protection is one block, compatibility is one block, enhancements is one block ... 1 ) Each block has a different zebra color (like you do with each line) 2) in complete wide resolution, we have 2 columns of blocks. If we go to lower rez, we have 1 column - this way the screen could be nicely filled. 3) if we have only 1 block - I need to think how to fill the screen in wide rez here ...

What do you think?

nguillaumin commented 4 years ago

So I tried this:

tech-details

And yeah the zebra alternating on blocks work better. However I think the previous version is more readable, because the labels / values are "aligned" (see red line below):

tech-details-2

So perhaps a mix of both?

tech-details-3

(I'm cheating as it's on a small screen here, on a large one it doesn't work well currently)

If you're happy with that (minus the responsiveness) I will put the change and we can merge, and look at the small screen sizes later?