search

atari-legend / legacy

Source code for the legacy AtariLegend site (Still used for the CPANEL)
https://legacy.atarilegend.com/
GNU General Public License v3.0
3 stars 0 forks source link

Fix #718: Button colors #738

Closed nguillaumin closed 4 years ago

nguillaumin commented 5 years ago

Also added a mouse over effect

stgraveyard commented 5 years ago

Very good job, much better. One remark, maybe we can fix this here as well ;

image

The file selector button is 'kaput' :-) I used to solve this with a label and javascript. Don't know if you agree with this way of working?

nguillaumin commented 4 years ago

Hm, I don't link it because it makes for a weird UX: You select a file, then it says "file(s) selected" nex to it which is a bit confusing:

upload1

Compare with:

upload2

Plus I think it's not super accessible with the label trick...

I think if we want a fancy file selector we should use an existing library like https://www.dropzonejs.com/ for example.

So perhaps merge this for now, and create an new issue to replace the file selector at a later stage?

nguillaumin commented 4 years ago

This PR was about the buttons colors originally and had nothing to do with the file upload, so I suggest merging this for now. If you're unhappy with the file browser, let's open a new ticket in the project and discuss it there?