search

atari-legend / legacy

Source code for the legacy AtariLegend site (Still used for the CPANEL)
https://legacy.atarilegend.com/
GNU General Public License v3.0
3 stars 0 forks source link

MAIN SITE - BUG - Interview main page #742

Closed stgraveyard closed 3 years ago

stgraveyard commented 4 years ago

Just noticed while adding a new interview ON DEV that the enlargement of the picture of the person interviewed doesnit use are regular script anymore. It does still seem to work on the PROD version.

nguillaumin commented 3 years ago

I cannot reproduce this, so closing it.

stgraveyard commented 3 years ago

Nico,

Now it also doesn't work on prod anymore. It is no big deal, but it's all in the details, right? ;-) Here is what I mean.

When going to the main review page and you click on a screenshot, enlargement looks like this :

image

Keeping the main page in the BG, because we have a script for this.

Now when doing this on the main interview page :

image

(it acts like a link to a photo overthere).

That was what I meant.

nguillaumin commented 3 years ago

Ok, I misunderstood, I'll have a look.

nguillaumin commented 3 years ago

I could not find trace of that in the Git history so I wonder if that ever worked :wink: but it was easy enough to add. Fixed on dev.

stgraveyard commented 3 years ago

Are you sure, doesn't work for me on dev.stonish.net?

nguillaumin commented 3 years ago

Duh, I forgot to push my changes! Will do tonight.

stgraveyard commented 3 years ago

I currently have no AL offline, so if it is ok with you I like to test on dev for awhile until I jump on the code bandwagon...

nguillaumin commented 3 years ago

It does work on the dev server for me actually, I did push my changes yesterday. But I think we're still not talking about the same thing :wink: I added the lightbox here:

lb1

But you want it here:

lb2

So I'll make another change.

nguillaumin commented 3 years ago

Ok this should be fixed for good now, working on dev!