atarw / material-ui-swing

A modern, Material Design UI for Java Swing
MIT License
656 stars 87 forks source link

Fix for nested JTree view #103

Closed mikera closed 4 years ago

mikera commented 4 years ago

The JTree view did not seem to be laying out the children correctly in nested mode (i.e. a root node with children)

I traced this issue to having a "null" icon for leaf nodes, which causes the indent of the leaf nodes to be incorrect.

This PR fixes the issue by adding a small transparent ICON to use for leaf nodes.

vincenzopalazzo commented 4 years ago

Also @mikera, in this project there isn't the last version of code, you should be follower the developer project vincenzopalazzo/material-ui-swing in the development branch.

The developer branch is tester each week with and big project how JMars and with these tests, we can have the feedback to the last code.

I want say you this just if you have interesting to work with the last code of the project.

mikera commented 4 years ago

Hi @vincenzopalazzo happy to help out - seems like a good and useful project, I often want to create simple but good-looking GUIs in Swing.

Can you just clarify - you want new PRs to be sent against against the "development" branch suggested above, rather than the main "master" in this fork?

vincenzopalazzo commented 4 years ago

Hi @mikera,

Hi @vincenzopalazzo happy to help out - seems like a good and useful project, I often want to create simple but good-looking GUIs in Swing.

Thanks

Can you just clarify - you want new PRs to be sent against against the "development" branch suggested above, rather than the main "master" in this fork?

Yes, if you want within future PR you can use the last version of code. After the testing, the stable version I will do push inside this branch.

For this PR I will push inside this master but in the future for me is more simple testing the code and noted the problem in the developer branch.

mikera commented 4 years ago

OK thanks. I will do any work on your development branch in future.

vincenzopalazzo commented 4 years ago

Hi @mikera, thanks you, if you complete this PR I will merge with the master

vincenzopalazzo commented 4 years ago

This PR was merged inside the correct fork and now are available on version 1.1.1.