search

atarw / material-ui-swing

A modern, Material Design UI for Java Swing
MIT License
656 stars 87 forks source link

Corrected Typos #104

Closed TheRolfFR closed 4 years ago

TheRolfFR commented 4 years ago

Hi,

As we detailled las time, I corrected some typos in your code, including comments. I don't know know if you will accept them all because some change the name of the components but feel free to do whatever you want with them

vincenzopalazzo commented 4 years ago

HI @TheRolfFR,

Thanks for this work but I'm a little confused, why you merged my master branch "vincenzopalazzo/material-ui-swing" with "atarw/material-ui-swing"?

My branch has a hard fork because I will use gradle inside my project, Gradle helped me to make easy the integration test.

There are some point, like:

  1. Your refactoring should be inside vincenzopalazzo/material-ui-swing
  2. You should be work on development branch
  3. You can create PR inside vincenzopalazzo/material-ui-swing fork and I will do the integration test, only after the integration test will pass, your PR will be released in atarw/material-ui-swing project.

Also, the library is in the release cycle, at the moment is in the beta-release, a lot of people are using the version beta of the library and for respect their, We will refactor the functions name after official version 1.1.1.

Thanks for your work.

Stay safe in this period.

TheRolfFR commented 4 years ago

Wooops,

I didn't do it on purpose, I will do that when I will have time.

Stay safe too.

vincenzopalazzo commented 4 years ago

Hi @TheRolfFR,

Take your time.

I'm closing this PR because is impossible to merge it