search

atarw / material-ui-swing

A modern, Material Design UI for Java Swing
MIT License
653 stars 86 forks source link

Opaque buttons that are set to false are rendered pixelated because the border is not valid #73

Closed Reap00r closed 5 years ago

Reap00r commented 5 years ago

pixeledBorder In earlier version, the buttons looked nice

This is related to: https://github.com/atarw/material-ui-swing/issues/71

vincenzopalazzo commented 5 years ago

Hi @Reap00r,

Some problems were doubt to me, the fault of keeping the two versions aligned. sorry

Now I hope this problem is solved

Reap00r commented 5 years ago

Hi @vincenzopalazzo, it seems like the buttons look the same now, with or without opaque false. They don't look round at the edges as they are supposed to. This is how they look no matter what I set them to: noRoundBorder

vincenzopalazzo commented 5 years ago

Hi @Reap00r, can you give me an example on how you want me to paint the button when it is setOpache to true and when it is false? I tell you how I imagine it, when the button is opaque then it has the same color as the analogue panel when it is not opaque, it takes the color of the button set in the UIDefault, do you want this effect? sorry but I never had the need to use this swing feature which for some other components is useless, I leave you this reference from where I read something https://stackoverflow.com/q/2451990/10854225

Reap00r commented 5 years ago

Hi @vincenzopalazzo, sure, here is an example how it used to look in an earlier version of this project, ignore the hovering and the menu, I can't find a picture of an old button: GIFWorks

and if it is set to false, it should look like that again.

When it is set to true, it should look like that: noRoundBorder

Maybe you could checkout an older version of the repository and compare what change in between the version which changed the button to look pixelated.

vincenzopalazzo commented 5 years ago

Hi @Reap00r,

So the effect that should appear is:

When button.setOpache (true):

When button.setOpache (false):

Did I get it right?

vincenzopalazzo commented 5 years ago

@Reap00r After a long time I understand your problem, excuse my poor English skills but I'm going through a workload period.

I hope this bug no longer exists

Reap00r commented 5 years ago

@vincenzopalazzo no worries, you are trying your best and we are able to communicate with each other :) And now you understood what I wanted 👍

vincenzopalazzo commented 5 years ago

@Reap00r Thanks, the fix are inside this pull request.

I hope of the fixing the problem with this solution

Reap00r commented 5 years ago

@vincenzopalazzo thanks for the fix, now it looks as good as it used to :)

vincenzopalazzo commented 5 years ago

Hi @Reap00r, I noticed the presence of this error only after several days because it is a problem at one point in the code that we never touched and something like that didn't seem possible to me. But every time even the Graphics was used and not Graphics2d everything came out pixeled.

I say this also for informational purposes if I use graphics with the look and feel you might get pixeled drawings