search

atassis / react-codemirror-ts

Codemirror react wrapper made with typescript
MIT License
8 stars 1 forks source link

Please export EditorConfiguration #5

Closed domehead100 closed 2 years ago

domehead100 commented 2 years ago

The options for Codemirror is of type EditorConfiguration.

This type is not exported so when using the component options comes up as "any" type, thus intellisense/autocomplete is not available to see the available types in the editor (e.g., vscode).

A fix is to change "declare type CodemirrorProps" in index.d.ts to "export declare type CodemirrorProps", or in other words export the type for the options from the es module.

Thanks.

atassis commented 2 years ago

Haven't seen this during the weekend, will deploy a fix in a couple of days

atassis commented 2 years ago

So the EditorConfiguration is imported from `@types/codemirror', no need of double exporting it from this repo