ataulm / muvi

Apache License 2.0
39 stars 3 forks source link

Convert film detail to use dagger #17

Closed hitherejoe closed 5 years ago

hitherejoe commented 5 years ago

Converts the film-detail modules to use dagger instead of koin. Most of this work was the same as how the feed modules were handled, with a couple of differences (i'll outline those in those comments).

I also moved the LetterBoxdApi to be injected via the Core Module. There was a lot of duplicated code after moving to dagger, which didn't make sense to keep around. Because the letterboxd_api module did not have any dependencies on our project, I decided to keep that 'sdk' feel and have core manage it's injections, just like you would with another external library (as it currently felt like we were treating it that way). Let me know if there are any thoughts here!