search

ataulm / muvi

Apache License 2.0
39 stars 3 forks source link

Extract base domain + FilmDetail parsing #5

Closed ataulm closed 5 years ago

ataulm commented 5 years ago

We extracted a base domain module where we could keep models that would be shared throughout the app - like Image or FilmSummary.

In practice, this meant that all the domain models went here - I don't think there are any domain models left that are specific to a feature module.

Also added the parsing logic for Film including the directors and characters. The annoying bit is that images don't seem to be included for the cast - if we want them, we'd have to do an API call per actor. What do you think about just avoiding this for now? e.g. showing their initials instead or using robohash?

(Also there's a new API to fetch a list of films given an actor ID. This wasn't meant to be committed - I wanted to do it as part of the same PR where the actor-detail modules are added, but oh well.)

hitherejoe commented 5 years ago

Looks good! I'm onboard with robohash too, might seem a bit overkil lfor now to make a request per actor - we can always change it along the line if we want