search

ataustin / flyover

Visually compare distributions in data sets
https://ataustin.github.io/flyover/
Other
3 stars 0 forks source link

can we provide for custom base plot functions instead of ggplot2? #17

Closed ataustin closed 3 years ago

ataustin commented 4 years ago

investigate how base graphics might be incorporated into the listcol of the build_plots tibble. this will also affect how cognostics are computed since they will rely on the data stored in the gg object of each plot.

ataustin commented 4 years ago

This will also affect how plot modifications are used in build_plots via the plot_mods argument. If we stick with ggplot objects, we simply add plot_mods to the function call to customize the plot. But if plot_fun produces a different object, then plot_mods will have to be passed as an argument to plot_fun and thus to all the flyover plotting functions individually.

ataustin commented 3 years ago

This is a great deal of effort without much payoff. While base graphics are powerful, flyover is more about quick comparisons than elegant graphs, and ggplot2 suffices for those quick comparisons. Moreover it seems the easiest implementation would introduce other dependencies, which are not worth the added the complexity when the flyover dependencies are already so large.