ataylorme / Advanced-WordPress-on-Pantheon

MIT License
65 stars 32 forks source link

Add Lighthouse tests to pull requests #92

Closed ataylorme closed 6 years ago

ataylorme commented 6 years ago

Visual regression test passed!

View the visual regression test report

ataylorme commented 6 years ago

Lighthouse test passed! The score of 90 isn't worse than the acceptable score of 83 (5 less than the score of 88 on the master branch)

View the full Lighthouse performance report for non-headless-chrome-lighthouse and compare it to the Lighthouse performance report for the master branch

ataylorme commented 6 years ago

@stevector can you review this when you have time? I kept trying to get Chrome/Lighthouse to run in a Docker image on Circle CI.

I got it going in headless mode but ran into issues when I found out the headless version of Chrome doesn't support network throttling and was giving inflated performance scores.

I tried, unsuccessfully, to get Chrome running in non-headless mode with xvfb by making my own Docker image since there isn't an official one yet.

I found lighthouse-ci and was able to get the Lighthouse reports from that API and just store/parse the results.

ataylorme commented 6 years ago

Visual regression test passed!

View the visual regression test report

ataylorme commented 6 years ago

Lighthouse test failed! The score of 84 is worse than the acceptable score of 87 (5 less than the score of 92 on the master branch)

View the full Lighthouse performance report for non-headless-chrome-lighthouse and compare it to the Lighthouse performance report for the master branch

ataylorme commented 6 years ago

Lighthouse test passed! The score of 89 isn't worse than the acceptable score of 87 (5 less than the score of 92 on the master branch)

View the full Lighthouse performance report for non-headless-chrome-lighthouse and compare it to the Lighthouse performance report for the master branch

ataylorme commented 6 years ago

With Chrome 63 having headless network throttling and Lighthouse support I'll be running this locally instead of relying on a 3rd party API. See #93