Linting reports from a range of lines are being annotated on the end line instead of start line

ataylorme / eslint-annotate-action

A GitHub action that takes ESLint results from a JSON file and adds them as annotated pull request comments

MIT License

93 stars 33 forks source link

Linting reports from a range of lines are being annotated on the end line instead of start line #45

Closed lone-cloud closed 1 year ago

lone-cloud commented 2 years ago

I'm testing v2 and am not sure if this behaviour is preset in v1.

An an example, I see a linting error being reported for "#L15-L71". This action puts the annotation with the error on line 71 which doesn't seem intuitive to me. I think it would be best to highlight the start of the problem which is on line 15.

lone-cloud commented 2 years ago

The code in this repo looks correct to me. Perhaps github is just displaying it weirdly. Here's a screenshot of what I mean. I was expecting to see this on line 15, not 71.

2022-06-29 10_42_48-WEB-5846 add eslint annotations to PRs by egor-yolabs · Pull Request #2399 · yol

ataylorme commented 1 year ago

I believe start_line and end_line are being passed correctly to the GitHub API. I am going to close this as a GitHub UI error. If you there there is something I can do to resolve this I'm happy to revisit.