search

ataylorme / eslint-annotate-action

A GitHub action that takes ESLint results from a JSON file and adds them as annotated pull request comments
MIT License
88 stars 32 forks source link

Add option that sets whether to fail the Github Action on ESLint errors. #55

Closed KrijnL closed 1 year ago

KrijnL commented 1 year ago

The motivation behind this PR is that in our case, we don't want to fail the job that runs our automated tests and ESLint, but we do want the step summary to show a red 'x' in case of errors.

The PR makes it possible to set an input fail-on-error to false in which case the action will still pass, but the check that is created will show a failure status.

PS. I ran a npm run build but if there is anything else I need to do to build your action, please let me know!