only-pr-files default to true was a breaking change

ataylorme / eslint-annotate-action

A GitHub action that takes ESLint results from a JSON file and adds them as annotated pull request comments

MIT License

88 stars 32 forks source link

only-pr-files default to true was a breaking change #71

Closed goleary closed 2 months ago

goleary commented 8 months ago

Thanks for this useful project! I noticed something today that I think you should be aware of.

When only-pr-files with a default of true was added it broke certain lint rules we rely on like no-unused-modules. I don't see anything in the release notes about this input and only found it by combing through old issues.

At this point changing it to default false would also be a breaking change, so I don't think there's anything to do here other than be aware of future breaking changes.

ataylorme commented 2 months ago

Thanks for the note! I will be more careful with breaking changes going forward.

3.0.0 has been released. Please update any references to the v3 branch instead of v3-beta. Make sure to read the Changelog, breaking changes are documented there (GH_TOKEN input has changed)