atb033 / multi_agent_path_planning

Python implementation of a bunch of multi-robot path-planning algorithms.
https://atb033.github.io/multi_agent_path_planning/
MIT License
1.04k stars 256 forks source link

Saving to video currently does not work for lack of a canvas #10

Closed notger closed 1 year ago

notger commented 2 years ago

See title.

You need to define a canvas before you define the function-animation. I have some fixed and slightly cleaned up code, so if you invite me to the repo, I can push a PR, if you want.

Way to replicate issue: Try creating video output. You will get an error message that says that an object related to canvas is None and does not have a certain property.

atb033 commented 2 years ago

You don't need to be a member of the repo to make a PR.

Can you please make fork the repo and then make a PR from that fork? Please check this out in case you aren't familiar with that work-flow

notger commented 2 years ago

Thanks, so far never worked with forks. Will do.

notger commented 2 years ago

Here we go: https://github.com/atb033/multi_agent_path_planning/pull/11 .

atb033 commented 1 year ago

closing as the issue was not reproduced