search

atbcb / usab-uswds

Website for the United States Access Board, built on Federalist and USWDS.
https://www.access-board.gov
Other
5 stars 10 forks source link

Protocol for making suggestions back to USWDS #574

Open bruce-usab opened 4 years ago

bruce-usab commented 4 years ago

Kathy has made some improvements (for accessibility) that should be passed along to the USWDS folks

kengdoj commented 4 years ago
bruce-usab commented 4 years ago

Here is another small error:

From default Jekyll build from template, _includes/searchgov/form.html line 17 label for has a typo: <label class="usa-sr-only" for="extended-search-field-small">Search small</label>

Should just be: <label class="usa-sr-only" for="extended-search-field-small">Search</label>

bruce-usab commented 4 years ago

I have gotten positive email feedback from @afeijoo but my preference would be to submit our suggestions as pull requests. Assuming the bug fixes slow down in a couple weeks, I would like help navigating to the right repo.

afeijoo commented 3 years ago

@bruce-usab You can submit issues and PRs to https://github.com/uswds/uswds.

bruce-usab commented 3 years ago

@drewnielson and @kengdoj recently reminded me that we also didn't find the visual indication of one's location in main navigation menus to be sufficiently accessible. There is good visual highlighting, but no character-based indication, so nothing for someone using screen reading software to easily identify. We adding a right-pointing arrow → but might have used an asterisk or bullet or greater-than. The &rarr; is an html element, but not easily typed from a keyboard, and further consideration is warranted.

For a good example of this aspect of our implementation, please see: https://www.access-board.gov/about/

At the time, I assumed we would revisit our About menu, to see if we might generated it procedurally. Our current version closely tracks the source files from the USWDS template. It is also working well enough, so revisiting is not a high priority for us.