search

atbore-phx / sbam

Smart Battery Advanced Manager
MIT License
16 stars 4 forks source link

fix docs for power vs energy #28

Closed cybadger closed 1 month ago

cybadger commented 1 month ago

as a unit of measurement W (Watt) was used even though sometimes Wh (Watthours) was infered. Fixed to minimize confusion for new users

not to be a nitpicker, but since it confused me I thought it might help others since I really love this project! Thanks for all your effort!

atbore-phx commented 1 month ago

thanks @cybadger for this PR, i'll go into it this weekend making a new release integrating your PR and i'll also fix this issue by @andreapalisca: https://github.com/atbore-phx/sbam/issues/24 for the logs

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/v1.3.7@634b275). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v1.3.7 #28 +/- ## ================================================= Coverage ? 87.57% ================================================= Files ? 9 Lines ? 322 Branches ? 0 ================================================= Hits ? 282 Misses ? 31 Partials ? 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.