atc-project / atomic-threat-coverage

Actionable analytics designed to combat threats
Apache License 2.0
954 stars 157 forks source link

Conflicts merging in Sigma #155

Closed marcurdy closed 4 years ago

marcurdy commented 4 years ago

Basic build process has conflicts. Attempted manually outside of the script.

$ /atomic-threat-coverage/detection_rules/sigma$ git pull origin master From https://github.com/Neo23x0/sigma

yugoslavskiy commented 4 years ago

Hello @marcurdy !

Sorry for the inconvenience.

This is caused by ongoing activities around the First OSCD Sprint and its PR to Sigma repo.

For now we are using oscd branch of Sigma repo to construct all mappings and create all entities. We do that mostly to have more analytics in the knowledge base, that we are visualising in public.

Yes, it has conflicts with master branch, and Sigma repo maintainers are working on it.

There are multiple solutions for that case:

  1. hotfix: pull from oscd branch:
git pull origin oscd
  1. waiting: just wait a bit for PR to be merged.

  2. fixing on our side: we just switch everything back to master, decreasing amount of Detection Rules (mapped analytics in general).

What would be better to do? What do you guys think?

@marcurdy @mrblacyk @sn0w0tter

marcurdy commented 4 years ago

I found that deleting the git files from the sigma parent directory and doing a fresh clone of sigma works, but anything you want merged is lost.

yugoslavskiy commented 4 years ago

Great 👍

Since you've solved the issues on your side already, I think it make sense to close it.