search

atc0005 / go-nagios

Shared Golang package for Nagios plugins
MIT License
8 stars 3 forks source link

Update Range Check regexp #237

Closed Tommi2Day closed 8 months ago

Tommi2Day commented 9 months ago

fix #235

atc0005 commented 8 months ago

@Tommi2Day

Thanks for submitting this PR.

@infraweavers

As noted on GH-235, this set of changes comes from linting recommendations provided by the GoLand IDE.

Two warnings are present (repeated as applicable):

Do you have any concerns with applying the GoLand recommendations?

atc0005 commented 8 months ago

@Tommi2Day We can give this until early next week to give @infraweavers a chance to respond and plan to merge either way then.

If there are any issues that we aren't catching we can always back out the change later and document the specific reasoning behind a need for the earlier regex formats.

atc0005 commented 8 months ago

@Tommi2Day Since we've not heard any objections/corrections from @infraweavers I believe we can proceed with merging these changes.

Are you willing to rebase your PR branch? If not I can do so before the merge.

Thanks.

Tommi2Day commented 8 months ago

branch has been rebased with current master