search

atcollab / at

Accelerator Toolbox
Apache License 2.0
49 stars 32 forks source link

Inconsistent radon radoff between matlab and python #276

Closed swhite2401 closed 3 years ago

swhite2401 commented 3 years ago

In matlab element types are detected looking at attributes likes BendingAngle, PolynomB etc... while in python it checks the class. This leads to issues when a lattice in matlab can be generated with radiations on in multipoles. This lattice if imported in pyAT cannot be used as ring.radiation_off() does not handle multipoles.

It would to make sure the two implementations are consistent. As a temporary fix I will turn radiations in multipoles in ring.radiations_off()

willrogers commented 3 years ago

Can this be closed?

swhite2401 commented 3 years ago

Yes I will close it, matlab cannot handle classes anyway