at.fast_ring functions need to be cleaned up

atcollab / at

Accelerator Toolbox

Apache License 2.0

48 stars 31 forks source link

at.fast_ring functions need to be cleaned up #529

Open lcarver opened 1 year ago

lfarv commented 1 year ago

Agreed. I was about to fully rewrite both python and Matlab versions. It can be made much simpler!

lcarver commented 1 year ago

The initial implementation of pyat fast_ring was heavily influenced by the matlab version so the logic is quite similar and not very pythonic. It can be significantly improved.

lfarv commented 1 year ago

I have versions rewritten from scratch which are much cleaner !

swhite2401 commented 1 year ago

For periodic lattices I would suggest to always develop the ring before generating the fastring