search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

do not split elements with IdTablePass method #563

Closed oscarxblanco closed 1 year ago

oscarxblanco commented 1 year ago

This pull request temporarily fixes the atplot bug reported in issue #561 where atplot shows a wrong value of the tune due to the split of an element with pass method IdTablePass.

A pass method check has been added inside the local splitelem function.

Best regards, o

oscarxblanco commented 1 year ago

is there any more reviewers to add to this pull request ? Otherwise, should I 'squash and merge' ? 'rebase and merge' ? 'create a new commit' ?

Best regards, o

lfarv commented 1 year ago

I don't think this simple bug fix needs more discussion… So yo may "squash and merge" (the other choices are disabled). Thanks !