search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

BugFix: refpts=None in get_lifetime #580

Closed swhite2401 closed 1 year ago

swhite2401 commented 1 year ago

PR #577 introduced a bug when refpts=None, this PR fixes this issue

swhite2401 commented 1 year ago

@oscarxblanco sorry I overlooked the case where refpts=None in the previous PR, this one should fix the issue.

swhite2401 commented 1 year ago

Ok so I propose to merge this as it fixes an obvious bug, on the other hand it would be good to understand this segmentation fault, I you have more details could you report it as a separate issue (it is most likely originating from the c part of the code).

I usually never run LT calculation for the full lattice but rather on a subset of elements (typically magnets) so it is well possible that for very heavy computations some problems have passed through the various validations.

oscarxblanco commented 1 year ago

@swhite2401 ok, I will report the segmentation fault in another issue.

From my side, this fix could be merged.