Closed lcarver closed 1 year ago
lfarv
commented
1 year ago Unable to check the formula as it doesn't display in the github page viewer.
You can check the result here.
Good for me, except that there is no syntax highlighting in code blocks. Maybe use .. code:: python instead of .. code:: ipython3
lfarv
commented
1 year ago This is very nice !
A detail: could you put cross-reference links for the end notes, and also possibly links to the reference papers ? Apparently they are freely available:
swhite2401
commented
1 year ago This look fine for me too, adding links as @lfarv mentioned would be nice indeed
lcarver
commented
1 year ago All comments so far have been implemented. Simone only read half of the document so I wait a bit longer.
lcarver
commented
1 year ago ready for merge, needs final approval
Unable to check the formula as it doesn't display in the github page viewer. Nonetheless it can still be reviewed, and I encourage reviewers to propose or make modifications as they see fit.