search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Don't automatically cache the location of RF cavities #640

Closed lfarv closed 10 months ago

lfarv commented 11 months ago

This corrects #636. Caching the location of cavities slightly improved performance, but raised problems after modifying the lattice. Setting the cavpts ring property still works for accelerating the access to the cavities, but it's now the user's responsibility to use it or not, it's mo more automatically set.

The guide for cavity control is corrected.

lfarv commented 10 months ago

Hello @swhite2401. Could you please approve this one, which is pending for long now…

swhite2401 commented 10 months ago

Well this was a request of @lnadolski shouldn't he review this? I don't feel very comfortable with approving something I did not request and will not review...

swhite2401 commented 10 months ago

@lfarv, merging without approval is against what we have decided concerning the merge process and should be avoided. I agree this one is small and not problematic, but it would still be good that everyone complies to the rules we have set, thanks.