search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Fix attribute names in Simple Ring #655

Closed lcarver closed 1 year ago

lcarver commented 1 year ago

This PR addresses the main comments from @lfarv in #647 . However I would like to discuss a bit the other comments.

I don't feel that there is any added value allowing a twiss_in input for simple_ring. In order to generate a twiss_in style input, you need a ring to begin with. In this case it is much easier to use fast_ring to generate your new ring and not bother using simple_ring.

I cannot really envisage a scenario where I might have only the output of some tracking results (a sigma matrix) and then I have to find an equivalent lattice to give me these parameters (where I still have to provide tunes and other non-linear parameters).

lcarver commented 1 year ago

Thanks for your comments. I made the changes you suggest. I agree we can do the simple_ring modifications with twiss in and sigma_matrix at a later date.

Ready for merge, just needs reapproval. I will move onto your matlab branch now. Cheers,