search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Create BndStrMPoleSymplectic4RadPass #665

Closed catohxb closed 12 months ago

catohxb commented 1 year ago

Hung-Chun Chao created BndStrMPoleSymplectic4RadPass to include synchrotron radiation damping for the straight-geometry bending magnet.

lfarv commented 1 year ago

Any other comment? For me it's ok for merging.

swhite2401 commented 1 year ago

Ok for me!

swhite2401 commented 12 months ago

Anyone implementing these changes?

carmignani commented 12 months ago

I could do the change, but I'm not sure to be able to do a commit on the forked version of AT from @catohxb. I can do the change by creating a branch in the atcollab official AT and then a new pull request. I will do that tomorrow, unless @catohxb will change his version before.

carmignani commented 12 months ago

Ok, actually I could do the commit directly online from gitHub on the forked version.

swhite2401 commented 12 months ago

@carmignani If you add me as reviewer I can re-approve (needed after your changes and cannot be you)