search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Update build system #747

Closed lfarv closed 6 months ago

lfarv commented 6 months ago

In preparation for a distribution of PyAT on conda-forge, a few problems appeared:

  1. Compilation problem: conda forces the use of a C++ compiler defaulting to more recent standards. Code fixed,
  2. Need for a LICENSE file. The choice of a license for AT is still pending. A dummy LICENSE file says: "License pending",
  3. Fixed a bug where the OpenMP/MPI options were ignored in editable builds (pip install -e),
  4. The build is updated: setup.cfg is removed, the options are moved to pyproject.toml.

The distribution on conda-forge may be rediscussed once this PR is merged.

MJGaughran commented 6 months ago

PR looks fine, but are we waiting on anything for the license file decision?

lfarv commented 6 months ago

PR looks fine, but are we waiting on anything for the license file decision?

Just waiting for an agreement on the adequate license. I just opened a discussion #748 on that. If you have an opinion, you are welcome!

lfarv commented 6 months ago

Hi all,

The discussion on the license is now going on. Here is my proposal for this PR:

  1. We merge this PR as it is. This fixes the bug for editable builds, and allows me to continue testing locally conda builds,
  2. We choose the license for the next release of PyAT. This release may then be distributed on conda, if we decide so (a new release is anyway necessary for that).

If you agree, please have a look again and comment or approve.