atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

BugFix: normalization by 0 in get_timelag_fromU0 #758

Closed swhite2401 closed 5 months ago

swhite2401 commented 5 months ago

This PR is a follow-up of #757 For multiple RF systems the synchronous phase is solved numerically. The system was normalized to U0 to prevent tolerance issues for the search of the stable point in the the presence of large energy loss per turn. This normalization resulted in issue in get_timelag_fromU0 (called by findorbit6 and fastring) in the presence of multiple RF systems when radiations are off. This issue is resolve by applying the normalization only when U0>0.

swhite2401 commented 5 months ago

@lfarv, the macos-latest runs on the M1 chip and does not support python version < 3.10. Also matlab does not run on arm64 architecture.

For the tests to complete I have changed the runner config such that macos-13 is used for python <3.10 and for the matlab tests Is this ok for you?