atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

AT_2_Elegant changes N_KICKS to N_SLICES; adds RingParam #762

Closed oscarxblanco closed 1 month ago

oscarxblanco commented 2 months ago

Dear all, this PR fixes a small issue when using AT_2_Elegant reported in #761 .

The parameter N_KICKS has been replaced by N_SLICES. Additionally, the RingParam element in AT is translated as a MARKER for Elegant.

oscarxblanco commented 2 months ago

Dear @swhite2401 , who should review this PR ?

swhite2401 commented 2 months ago

I would do it but I am not an Elegant user... maybe @TeresiaOlsson could be a good candidate?

TeresiaOlsson commented 2 months ago

I can review it, but I might not manage until the end of the week if that is okay?

oscarxblanco commented 2 months ago

Dear @TeresiaOlsson , that is alright for me.

lfarv commented 2 months ago

@oscarxblanco and @TeresiaOlsson: I'm also not an Elegant user, but I'm currently upgrading the file input/output in PyAT. So I am very interested in getting sample Elegant input files. If you have some, could you post them? Thanks.

oscarxblanco commented 2 months ago

Dear @lfarv , here is a example of a unit cell. elegantconvertedlattice.lte.txt twiss.ele.txt

oscarxblanco commented 2 months ago

@lfarv , I forgot to explain how to run it in case you need it.

elegant twiss.ele

The output will be twiss.twi which is in sdds format. You could use sdds2spreadsheet to create a text file

sdds2spreadsheet twiss.twi twiss.txt
TeresiaOlsson commented 2 months ago

@lfarv I have added lattices for Diamond and Diamond-II in case you need some with a lot of different elements.

DIAD_nlbd_model_1storder.lte.txt

M_H6BA_38_1_1.lte.txt