search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Bug in piwinski touschek scattering B2 term #765

Closed swhite2401 closed 1 month ago

swhite2401 commented 2 months ago

The PR fixes the bug reported in #763. b2gi no multiplies only the first term of the B2 expression and the approximation made on the Bessel integral calculation is described in the help. PEP8 formatting is fixed on the file touschek.py

oscarxblanco commented 1 month ago

Dear @swhite2401 , I did a review about three weeks ago but there's been no changes. I have submitted the review again. There is still an error in the way you wrote the equation.

swhite2401 commented 1 month ago

@oscarxblanco there must have been some hiccup because I never received anything, I have now implemented the changes as described in you issue (second term multiplied by 4) as I should have from the beginning...

swhite2401 commented 1 month ago

@oscarxblanco this sometimes happens when you forget to push the submit button on your review

oscarxblanco commented 1 month ago

@oscarxblanco this sometimes happens when you forget to push the submit button on your review

You are right, I assumed it was published automatically. I needed to push the submit review button. Thank you @swhite2401

This last modification looks good to me.