atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

matlab atlinopt4 check on 6d is disabled #788

Closed oscarxblanco closed 3 months ago

oscarxblanco commented 3 months ago

Dear all,

the function atlinopt4 does the calculation without checking if the pass methods are 6d or 4d. The obsolete function check_radiation is commented and was not replaced.

https://github.com/atcollab/at/blob/5028aafee80175c8f207a902b271779c53ee255a/atmat/atphysics/LinearOptics/atlinopt4.m#L96

This is a problem because the closed orbit changes, and it produces an effect on the optics. I propose to set a warning if the lattice is 6d.