search

atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Severe bug introduced by #766 #790

Closed swhite2401 closed 1 week ago

swhite2401 commented 1 week ago

PR #766 has inttroduced severe bugs in the file loading system, some file now fail to load on the error:

AttributeError: property of 'Lattice' object has no setter

After a quick look the attributes failing are mat_key and mat_file. Adding these to the list of excluded attributes seems to fix the problem, but I do not understand why. The logic has become so complicated that it is presently impossible to understand or debug these functionalities, my feeling is that only @lfarv can do it in a reasonable time.

This is in clearly not acceptable and a complete review and simplification of these functionalities is strongly advised.

Meanwhile @lfarv could you please fix this bug? I attach a file that was saved with pyAT loads without any problem forversion prior PR #766 opt_ma.txt

lfarv commented 1 week ago

fixed in #791

lfarv commented 1 week ago

The problem is solved in #791. Release 0.6.1 has been uploaded