atcollab / at

Accelerator Toolbox
Apache License 2.0
48 stars 31 forks source link

Fix load mat #791

Closed lfarv closed 1 week ago

lfarv commented 1 week ago

This fixes a bug reported by @swhite2401 in #766.

lfarv commented 1 week ago

When this is approved, I will immediately publish a bug fix release 0.6.1. For this, the license in the project metadata is also fixed.

lfarv commented 1 week ago

For info, the .mat file contains strange attributes in the RingParam element. @swhite2401, can you remember if this file was created by a recent version? Anyway these strange attributes are now ignored.

swhite2401 commented 1 week ago

For info, the .mat file contains strange attributes in the RingParam element. @swhite2401, can you remember if this file was created by a recent version? Anyway these strange attributes are now ignored.

This is an old version because this is the environment I create for FCC studies a while ago, can remember exactly when

lfarv commented 1 week ago

can't we just assume that the lattice can have any attribute?

Yes, that's what it should be. The problem appeared with "deprecated attributes" which were kept for compatibility as properties. This created the bug and is now solved.