atdrupal / at_base.module

Provide some more API for developer to work with Drupal (7).
https://drupal.org/project/at_base
GNU General Public License v2.0
5 stars 4 forks source link

[Insight] Boolean property should not be prefixed by "is" #229

Closed and1truong closed 9 years ago

and1truong commented 10 years ago

in lib/Cache/Warming/Warmer.php, line 50

Boolean property accessor should not be setIsXXX nor getIsXXX but setXXX and isXXX.

    $this->event_name = $event_name;
    $this->tag_discover->setEventName($event_name);
    return $this;
  }

  public function setIsSubProcess($is_sub_process = FALSE) {
    $this->is_sub_process = $is_sub_process;
    return $this;
  }

  public function setContext($context) {

Posted from SensioLabsInsight