search

atelierbram / Base2Tone-VSCode-Themes

Duotone themes for VS Code
https://marketplace.visualstudio.com/items?itemName=Atelierbram.base2tone-vscode-themes
MIT License
11 stars 2 forks source link

Removed empty fontStyle declarations to allow user italic settings #3

Closed apiontek closed 6 years ago

apiontek commented 6 years ago

I use italic settings in my user settings, which doesn't work in this theme with all the "fontStyle": "" lines overriding them.

I removed all the empty fontStyle declarations and now my user settings for italics in some places all work.

atelierbram commented 6 years ago

Thanks for the PR. I believe there is a way within user settings to override these empty fontStyle declarations within so called "scoped styles".

How do I get Visual Studio Code to display italic fonts in formatted code?

But I can see how this might be a lot of work, so I will merge this and see how this works out; not just for me but also for others. So if this will lead to issues for other people, I might revert these edits.