search

atelierbram / Base2Tone-vim

Base2Tone - duotone - Themes for Vim
MIT License
124 stars 5 forks source link

Specify terminal colors for neovim #4

Closed justanotherdot closed 6 years ago

justanotherdot commented 6 years ago

Thanks for the port of this awesome colorscheme!

I've been using the PoolDark colors for well over a year now but realised that the terminal colors in vim weren't specified. This seems to resolve that by using the same gui<hex> colors.

atelierbram commented 6 years ago

Thanks! I had reinstalled my OS but not yet Neovim - that's what I did just now out of curiosity - and it seems to pick the colors up just fine! I'm going to merge this in a bit, and after pulling it down I will rebuild it with the base16-builder tool, (if only for consistency) from the template. Just to let you and others know there will me a commit after this, with the same result (except maybe for some whitespace ).

justanotherdot commented 6 years ago

Just as an aside, I couldn't seem to get foreground or background colors to change, even when I specified a single color across all possible 256 values (let g:terminal_color_[0-255] = "#000000", for example), which doesn't really matter here since the colors seem to line up nicely with the rest of the theme but I thought I'd mention in case it's an issue brought up in the future.

atelierbram commented 6 years ago

Oh, I see - I hadn't noticed since I have the same theme installed on my Hyper terminal as the one I initially tested it with, so it totally blended in ;). Maybe I make this into an issue, for another day (or someone else) to figure out. Thanks again, it's great!