Closed dustinfarris closed 6 years ago
I fixed the tests and squashed the commits. I've also tried it out on my staging server and I am able to create tenants and run migrations. This is ready for review and testing.
To try it out, use my fork of triplex:
# mix.exs
{:triplex, github: "dustinfarris/triplex", ref: "1340d22"},
mix do deps.clean triplex, deps.get
Everything should be the same, except it now works in OTP releases. Please report back if it works or does not.
/cc @vinceurag @kelvinst
Thanks for this @dustinfarris. I'm on my work now and will be trying this. Will get back to you with results. Have a nice day!
@dustinfarris I just tested it now. It works!! Thank you!
@kelvinst I verify that this fix works. :)
@dustinfarris thanks for the fix! I'm merging it to master now and will do a release until the weekend!
@dustinfarris can you please rebase it with the current master?
@reimo can you check if this fixed #41 too? It guess it has, can you check it please?
@dustinfarris, I've added some adjusts to you code... 😉
@kelvinst got my forked repo to work 2 days ago, was hoping to make a pr later this week Anyway, hope this PR sort that.
@kelvinst rebased!
Perfect! :)
Fixes #45.
I'm not sure if this is the best approach, but I think it could be a workaround at least.
There are still a couple failing tests I am working to resolve.