search

atellmer / dark

The lightweight and powerful UI rendering engine without dependencies and written in TypeScript💫 (Browser, Node.js, Android, iOS, Windows, Linux, macOS)
MIT License
40 stars 1 forks source link

`platform-server` Bun compatibility #42

Closed Coachonko closed 3 months ago

Coachonko commented 3 months ago

@dark-engine/platform-server contains the statement import { Readable } from 'node:stream'. Readable is global, it doesn't need to be explicitly imported. Bun implements the Node Readable class. Commenting out the import statement allows @dark-engine/platform-server to successfully run on Bun.

Will verify and update

Coachonko commented 3 months ago

Actually works fine. @dark-engine/platform-server is compatible with Bun.

atellmer commented 3 months ago

I'm not sure that Readable is global object in Node.js but thanks for your point. I haven't had to use Bun yet and I'm glad it works.