atenpas / gpd

Detect 6-DOF grasp poses in point clouds
BSD 2-Clause "Simplified" License
606 stars 233 forks source link

Output for tutorials/table_mug.pcd #89

Closed seann999 closed 4 years ago

seann999 commented 4 years ago

The output of ./detect_grasps ../cfg/eigen_params.cfg ../tutorials/krylon.pcd looked good, but the output for ../tutorials/table_mug.pcd generates grasps that are far off from the point cloud (at least for me). Is this expected, possibly due to the need of adjusting values in the cfg, or not?

atenpas commented 4 years ago

Yes, this is to be expected. To find grasps on the mug, you have to modify the cfg. The file ../tutorials/table_mug.pcd was part of an old tutorial that does not work with this version of the code anymore. You would want to segment the table and/or use a workspace filter for this file. In general, you always want to customize the cfg for your robot, environment, etc.

atenpas commented 4 years ago

Closing this for now.

huiwenzhang commented 1 year ago

Yes, this is to be expected. To find grasps on the mug, you have to modify the cfg. The file ../tutorials/table_mug.pcd was part of an old tutorial that does not work with this version of the code anymore. You would want to segment the table and/or use a workspace filter for this file. In general, you always want to customize the cfg for your robot, environment, etc.

@atenpas why the table_mug.pcd is out of date? I checked the code, the candidate grasps are far from the point cloud is because the sampled origins are wrong. However, according to the visualization code below,

void Plot::plotSamples(const std::vector<int> &index_list,
                       const PointCloudRGBA::Ptr &cloud) {
  PointCloudRGBA::Ptr samples_cloud(new PointCloudRGBA);
  for (int i = 0; i < index_list.size(); i++) {
    samples_cloud->points.push_back(cloud->points[index_list[i]]);
    std::cout << index_list[i] << std::endl;
  }

  plotSamples(samples_cloud, cloud);
}

the sampled cloud is absolutely part of the processed cloud. Why the figure shows that they are from different cloud? As shown in the figure below, points in pink color are sampled points.

image