search

atenreiro / opensquat

The openSquat is an open-source tool for detecting domain look-alikes by searching for newly registered domains that might be impersonating legit domains and brands.
https://opensquat.com
GNU General Public License v3.0
685 stars 130 forks source link

Why the "dnspython" requirement version is locked to a specific and obsolete one ? #84

Closed maaaaz closed 1 year ago

maaaaz commented 1 year ago

Hello there,

Everything is in the title :) https://github.com/atenreiro/opensquat/blob/295d58a4f33723d5985cadbfb4984401e9ee84ed/requirements.txt#L14

Cheers!

atenreiro commented 1 year ago

Hello!

There was a bug with the latest version of dnspython available at that time, hence I fixed into a specific build to prevent the issue.

I rever revisit the latest releases to confirm that the big as been fixed but thanks for pointing this out.

maaaaz commented 1 year ago

Hello there,

I dug, and indeed the current code use the query deprecated function. Here a test using your code with the latest dnspython version:

>>> import dns.resolver
>>> my_resolver = dns.resolver.Resolver(configure=False)
>>> my_resolver.nameservers = ['9.9.9.9']
>>> my_resolver.search = []
>>> my_resolver.query("google.fr", "A")
<stdin>:1: DeprecationWarning: please use dns.resolver.Resolver.resolve() instead
<dns.resolver.Answer object at 0x7f381af2af50>

I fixed it by using "resolve" function instead of "query": I use that new function is one of my script

Cheers !

atenreiro commented 1 year ago

Fixed in the pull #85