search

aternosgames / concepts

Concepts for Aternos Games
https://concepts.aternos.games/concepts/
2 stars 2 forks source link

Create labels for all repositories #15

Closed matthi4s closed 5 years ago

matthi4s commented 5 years ago

Generic labels: Status (Darkgrey: #2d3943): New, Confirmed, Planned, In progress, Waiting for review, In review, Reviewed, Needs changes, Done, Duplicate, Wontfix, Denied, Invalid Type (Blue: #1269D3): Feature request, Enhancement, Bug Priority (Yellow: #E4E570): None, Low, Minor, Major, Critical (Red: #D53C4E) Effort (Green: #118572): 10 minutes, 1 hour, Several hours, Several days, Several weeks Flag (Darkblue: #0c396a): Good first issue, Help wanted

Specific labels: Category (#A3EEEF)

ghost commented 5 years ago

I sat done a while ago and managed the labels of GoMint, where I'm a member of the organisation and also an issue manager. I designed those labels and I think for most of the repositories we have, they would fit right in, imho.

image image image image

Now, I'd suggest to change the colors though, because the colors don't look very appealing to the eye, if you've got a bunch of issues with many labels on them.

image

Let me know what you think.

matthi4s commented 5 years ago

What is the purpose of the numbers on labels for categories or components? Removing/adding labels could mess up with the numbers. Also, I think we should start with fewer more general labels such as status, type etc.

I agree, that there should be a better color scheme for the labels. Compared to the current labels I also think writing everything lowercase looks better.

vainamov commented 5 years ago

I personally prefer uppercase for labels tbh.

ghost commented 5 years ago

I didn't get that either having numbers on labels. I guess it is for some parsing stuff for later on. I think leaving them out wouldn't be that much of a big deal.

ghost commented 5 years ago

I personally prefer uppercase for labels tbh.

Full uppercase like THIS or just the first Letter uppercase?

Mvmo commented 5 years ago

I personally prefer uppercase for labels tbh.

Full uppercase like THIS or just the first Letter uppercase?

I guess just the first letter

matthi4s commented 5 years ago

All right then, I would suggest the following labels:

Status: New, Confirmed, Planned, In progress, Waiting for review, In review, Reviewed, Needs changes, Done, Duplicate, Wontfix, Denied, Invalid Type: Feature request, Enhancement, Bug Priority: None, Low, Minor, Major, Critical Effort: 10 minutes, 1 hour, Several hours, Several days, Several weeks Flag: Good first issue, Help wanted

These labels are pretty generic, we could agree on names for more project specific labels such as Component, Category etc.

ghost commented 5 years ago

I didn't get the point of having a label for "Wontfix" yet. What's the use of such label? If something's not gonna get fixed for whatever reason you close the issue or the pull request?

matthi4s commented 5 years ago

But you also close issues after you've finished them, the label would make it easier to directly see the status of this bug or whatever instead of scrolling through the comments to find the reason for closing the issue.

ghost commented 5 years ago

Hm okay.

ghost commented 5 years ago

Anybody got any preferences regarding label colors?

matthi4s commented 5 years ago

I think every "category" (Status, Type, Priority etc.) should get one single color. We could use colors from here: https://design.aternos.org/

ghost commented 5 years ago

Having a single color for each category is the right thing, but, and there's a but, issues/labels which are of critical priority should not have for example a blue color or so. Let's say we have those labels: Priority: None, Low, Minor, Major, Critical I'd assign the base color to "None" and increase either the brightness or darkness of the color for each priority going up and at the end "Major" and "Critical" fade into a bright red. It draws more attention.

matthi4s commented 5 years ago

I wouldn't use too many colors, maybe one color for all priorities except Critical, which gets a bright red or something like that.

ghost commented 5 years ago

Aight

matthi4s commented 5 years ago

I would suggest these colors:

Status (Darkgrey: #2d3943): New, Confirmed, Planned, In progress, Waiting for review, In review, Reviewed, Needs changes, Done, Duplicate, Wontfix, Denied, Invalid Type (Blue: #2b87d3): Feature request, Enhancement, Bug Priority (Orange: #eb7b59): None, Low, Minor, Major, Critical (Red: #f62451) Effort (Green: #1fd78d): 10 minutes, 1 hour, Several hours, Several days, Several weeks Flag (Darkblue: #0c396a): Good first issue, Help wanted

ghost commented 5 years ago

Also, I wouldn't label "Effort" labels with actual time but instead with something like this "Easy, Hard, Very Hard" etc. and put the estimated time into the description of the label.

matthi4s commented 5 years ago

I thought it would be easier to understand the meaning, because "easy, hard, etc." can mean anything and by directly stating the estimated time it's much clearer what size this issue has.

ghost commented 5 years ago

The issue with this is, if you label it with something like "10 minutes" or a relative low amount of time, people are gonna start asking "why u no fixing dat issue". There may be other issues that need to be resolved first or something else. Labeling it with just "easy", "middle" etc. softly prevents this. To be honest, I don't want people tagging me all the time asking why this and this is not fixed even though the issue is labeled with "10 minutes"

matthi4s commented 5 years ago

This is the reason for the priority labels if it's clearly stated as "Low" or even "None", there is nothing to argue about. Also, on the other hand, a "10 minutes" issue might motivate other developers to contribute, because it's clearly stated as a task for 10 minutes.

ghost commented 5 years ago

Fair enough.

ghost commented 5 years ago

I'm going to add the standard labels for all existing repositories.

matthi4s commented 5 years ago

Maybe we start with one slightly active repository like this one (concepts) so we can see how it looks?

ghost commented 5 years ago

Sure enough.

ghost commented 5 years ago

What's the format btw.? Status: New or New

matthi4s commented 5 years ago

Status: New - I would keep it consistent and some labels such as None (priority) wouldn't make much sense.

ghost commented 5 years ago

Alright.

ghost commented 5 years ago

Sample labels added. Have a look.

matthi4s commented 5 years ago

Hmm, I'm not really happy about the GitHubs text color choice.

ghost commented 5 years ago

I'm gonna try to tweak the colors so they nicely fit with each other.

ghost commented 5 years ago

Is it better now?

matthi4s commented 5 years ago

I've changed some label colors to colors from GitHubs announcement about new label colors: https://twitter.com/github/status/954467266434945024

ghost commented 5 years ago

Looks good imo.

matthi4s commented 5 years ago

I've changed the Concepts labels to Category to be more fitting for other repos and updated the first comment containing the new color codes.

ghost commented 5 years ago

Labels of all repositories are being cleared and replaced with the new ones. Issue resolved.