aternosorg / mclogs

Paste, share and analyse Minecraft logs

https://mclo.gs

MIT License

185 stars 33 forks source link

Suggestion: map methods and fields using mappings #136

Open viciscat opened 1 month ago

viciscat commented 1 month ago

Can yall understand Cannot invoke "net.minecraft.class_1087.method_4709()" because "$$7" is null? Cuz I sure can't.

It would be nice to have an option to map vanilla methods and fields with Yarn or Mojang mappings.

(is map the correct verb?)

PS: thanks for making this website btw :heart:

JulianVennen commented 1 month ago

We already use mappings for stack traces, mapping stuff in specific error messages is a little harder as it likely requires work on each error kind

viciscat commented 1 month ago

Yea I just realized that the website maps the methods normally while looking at another crash report, sorry about that. It's just that this one -> https://mclo.gs/g4eGYzo didn't get mapped. (due to the knot// thing I presume)

JulianVennen commented 1 month ago

Yeah, I think that's new. I'll look into both of these, probably sometime next week

JulianVennen commented 2 weeks ago

140 resolves the issue with the knot// prefix.

I looked at some things for matching class names in other places like exception messages but found no satisfying solutions. Yarn mappings can probably be applied with a replace all attitude without false-positives, but that doesn't work for vanilla.