search

aterrien / jQuery-Knob

Nice, downward compatible, touchable, jQuery dial
http://anthonyterrien.com/knob/
MIT License
5.04k stars 1.24k forks source link

Circle does not draw at all in IE 8 #150

Open DavidAcreman opened 10 years ago

DavidAcreman commented 10 years ago

Please see the screenshot below of IE 8 problem (this is using excanvas3 to get it to work at all)

http://screencast.com/t/tA3ujO4BEu9W

It should work as shown in this screenshot from Chrome of the same code:

http://screencast.com/t/SxhBec3mWNr

I am using the jquery.knob.js file from the HEAD of this repo, and there is little to no documentation / information on why this should be happening in IE8.

I have followed the steps in this stackoverflow (with the exception of editing the knob.js file as they suggest, as the HEAD version of the file incorporates this code already)

http://stackoverflow.com/questions/14743161/jquery-knob-not-working-in-ie-8/15291947#15291947

zitrusblau commented 10 years ago

try my temporal fix: https://github.com/zitrusblau/jQuery-Knob

DavidAcreman commented 10 years ago

Fix works to get the dial drawing - thanks! Now it seems that when it is set to 0 it doesn't draw quite the whole way round. Also the angle offset appears to work strangely - see the screenshot below and the difference between it set to 9 and 88.

Thank you again for the fix, it will keep my project on track (as my javascript is rubbish sadly!) :)

http://screencast.com/t/0uGa6voK

aterrien commented 10 years ago

@zitrusblau: I've merged your great patch for IE8, I don't have any IE8 vm at home :(, can you validate the head (1.2.4) ?

zitrusblau commented 10 years ago

Hey,

the gap on max-value was there all the time, wasn't it.

are you having the other issue only on IE 8 or with all browsers. could you specify more precisly, how your knobs are set up?

Daniel Klotz

ZITRUSBLAU GmbH Keithstraße 41 · 10787 Berlin www.zitrusblau.de Fon 030.257 587- 84 Zentrale 030.214 777- 00 Fax 030.214 777- 01

Am 09.01.2014 um 10:59 schrieb DavidAcreman:

Fix works to get the dial drawing - thanks! Now it seems that when it is set to 0 it doesn't draw quite the whole way round. Also the angle offset appears to work strangely - see the screenshot below and the difference between it set to 9 and 88.

Thank you again for the fix, it will keep my project on track (as my javascript is rubbish sadly!) :)

http://screencast.com/t/0uGa6voK

— Reply to this email directly or view it on GitHub.

zitrusblau commented 10 years ago

hey,

just check in IE Tester for IE 8 VM and it works quite nicely. don't have a native IE 8 here to test, though.

Daniel Klotz

ZITRUSBLAU GmbH Keithstraße 41 · 10787 Berlin www.zitrusblau.de Fon 030.257 587- 84 Zentrale 030.214 777- 00 Fax 030.214 777- 01

Am 09.01.2014 um 22:55 schrieb Anthony Terrien:

@zitrusblau: I've merged your great patch for IE8, I don't have any IE8 vm at home :(, can you validate the head (1.2.4) ?

— Reply to this email directly or view it on GitHub.

DavidAcreman commented 10 years ago

I don't see the gap on Firefox or Chrome when viewing the same web page with the same data on it.

The markup I am using is below (also have linked it as Github doesn't like me adding script / markup directly into my comment) http://screencast.com/t/33y9ND0qdFu

DavidAcreman commented 10 years ago

IE8: http://screencast.com/t/GhKGV8QR FF 26.0: http://screencast.com/t/xoIpjRD9M Chrome 31.0.1650.59 m: http://screencast.com/t/rQ3bOhwT

As you can see IE always has a tiny gap at minimum or max value!

TheBokiya commented 10 years ago

I have this problem which IE doesn't draw the circle if the readonly value is equal to the max value. Very weird.