ateucher / rmapshaper

An R wrapper for the mapshaper javascript library
http://andyteucher.ca/rmapshaper/
Other
200 stars 13 forks source link

Fix version comparison w/ `v8_version()` #173

Closed elipousson closed 2 months ago

elipousson commented 2 months ago

I ran into some issues with the version comparison using v8_version() that should are fixed by this PR.

ateucher commented 2 months ago

Thanks for finding and fixing this! This is due to a new constraint added in R 4.4.0:

The numeric version creators now stop on invalid non-character version specifications.

From https://cran.r-project.org/doc/manuals/r-release/NEWS.html.

I added two more:

elipousson commented 2 months ago

Thanks! I couldn’t figure out exactly when it started but it drove me crazy until I caught it. Appreciate the quick review and merge.

ateucher commented 2 months ago

Thanks for reporting and fixing it!