Issues with Essentials legacy items mode - Githubissues

atferrys / ModdedIntegration

🔌⛏️ A Minecraft Plugin that auto-populates the EssentialsX's items.csv file with Forge items and blocks.

GNU General Public License v3.0

8 stars 4 forks source link

Issues with Essentials legacy items mode #3

Open RadsJog opened 2 years ago

RadsJog commented 2 years ago

I am having issue with items.csv I am using Modintrigation 1.3 latest one and after I used it all the modded items added to items.csv but from the modded items I am only able to /give some and not all how to fix it

atferrys commented 2 years ago

Hi! To help you resolve the problem I first need some extra Infos:

The version of Minecraft in use
The version of Magma in use
The modlist
Some examples of which items can be given or not
Server logs

RadsJog commented 2 years ago

Ok so

1.16.5 forge 36.2.33
Magma 1.16.5-36.2.33-329ceacb
SizeUpappleskin-forge-mc1.16.x-2.4.0 (1).jar46.62kBBetterAdvancements-1.16.5-0.1.0.108.jar61.78kBchat_heads-0.6.0-forge-1.16.5.jar27.13kBcloth-config-4.14.54-forge.jar1.39MBcomforts-forge-1.16.5-4.0.1.5.jar221.73kBCosmeticArmorReworked-1.16.5-v4a (3).jar85.27kBcurios-forge-1.16.5-4.0.5.3.jar240.51kBCustomNPCs-1.16.5.20220226.jar11.85MBFastLeafDecay-v25.2.jar8.43kBgoblintraders-1.6.0-1.16.3.jar418.31kBironchest-1.16.5-11.2.13.jar215.46kBitemblacklist-1.16.5-1.2.0.jar21.27kBjei-1.16.5-7.7.1.147.jar807.93kBKimetsuAnimation_1.16.5_ver4.jar104.85kBKimetsunoYaiba_1.16.5_ver38.2 (3).jar20.88MBmcw-bridges-2.0.2-mc1.16.5.jar645.53kBmcw-roofs-2.1.0-mc1.16.5.jar1.54MBmodnametooltip_1.16.2-1.15.0.jar9.98kBobfuscate-0.6.2-1.16.3 (9).jar147.63kBpamhc2crops-1.16.3-1.0.2.jar785.21kBpamhc2foodcore-1.16.3-1.0.2.jar321.12kBpamhc2foodextended-1.16.3-1.0.4.jar1.84MBpamhc2trees-1.16.3-1.0.1.jar532.56kBswingthroughgrass-1.16.4-1.5.3.jar22.42kBsworddisplay-1.16.5-1.2.0.jar194.08kBtorohealth-1.16.4-forge-4.jar94.16kBTravelersBackpack-1.16.5-5.4.7 (1).jar338.50kBwalljump-forge-1.16.4-1.3.7.jar82.55kBWaystones_1.16.5-7.6.4 (1).jar MODS LIST
for ex when I try to do /give AsahiSenju kimetsunoyaiba_akaza_head it doesn't work latest (5).log

atferrys commented 2 years ago

Ok, I'll check that tomorrow and I'll let you know ASAP.

RadsJog commented 2 years ago

So did you got smth

atferrys commented 2 years ago

I've installed the mods but there isn't any "akaza_head" even in the creative menu

atferrys commented 2 years ago

Ok, i've checked and other items present in the creative menu aren't showing up in essentials items

atferrys commented 2 years ago

Seems like some items from that mod have a numeric id equal to -1. _(Ex. kimetsunoyaiba_clothes_bamboochestplate,-1,0) The numeric ids are deprecated by 1.13 but, due to essentials items "legacy mode" (basically CSV with numeric ids instead of JSON with string ids) triggered by Magma patching, they are still needed in order to populate the file. So the problem is either on the Mod part or the Magma part.

RadsJog commented 2 years ago

So if I change the value will it be get fixed

RadsJog commented 2 years ago

Is there any chance It can be fixed or any alternative

atferrys commented 2 years ago

So if I change the value will it be get fixed

The value in the items file? I don't think so

LeStegii commented 2 years ago

What exactly would we need to change in order to NOT trigger legacy mode?

atferrys commented 2 years ago

I am not sure why the legacy mode triggers. I've tried using other hybrid server implementations and pure spigot and instead of items.csv, Essentials uses an items.json file.

It might be one of the patches applied when starting up the server ([main/INFO] [FML]: Essentials [Fixes Commands in Essentials] loaded), but i'm not entirely sure since the patch is only about commands 🤔