search

atg / chocolat-public

Public bug tracker for the private chocolat project
http://chocolatapp.com
180 stars 4 forks source link

Unicode - CJK - Chinese characters are not handled well #1433

Open chengguangnan opened 10 years ago

chengguangnan commented 10 years ago

What I typed is "一二三" (means 1, 2, 3).

screen shot 2013-10-07 at 2 27 59 pm

It shows up correctly if I append an Enter

screen shot 2013-10-07 at 2 28 30 pm

Basically, it mess up if you try to add or edit some Chinese.

Here is one more example, what I entered is "百" (sounds "bai"

screen shot 2013-10-07 at 2 31 19 pm

But while selected the character "百"，it becomes something else!

screen shot 2013-10-07 at 2 32 31 pm

Now if I enter something else, it will be displayed as "百" again.

screen shot 2013-10-07 at 2 33 28 pm

atg commented 10 years ago

Yeah this is an important thing to fix. If the file contains non-ASCII characters we need to take the slow path for glyph generation like we do for non-Menlo fonts. I don't know why I didn't think of that before, actually.

The hard bit is figuring out how to keep that information up to date. Maybe put it in CHLineMarker or something