atg / chocolat-public

Public bug tracker for the private chocolat project
http://chocolatapp.com
180 stars 4 forks source link

[ALERT] Serious serial key activation flaw #1724

Open ishraq0 opened 9 years ago

ishraq0 commented 9 years ago

If you fill the text field with spaces (15, most likely) instead of the actual serial key, it will activate Chocolat. Found this when messing about and stuff. (It worked for me.)

locks commented 9 years ago

Could not reproduce.

ishraq0 commented 9 years ago

screen shot 2015-04-06 at 10 47 36 pm Will this screenshot help?

locks commented 9 years ago

No, I still can't reproduce.

locks commented 9 years ago

What version is your Chocolat?

ishraq0 commented 9 years ago

Version 3.1.4 (3.1.4)

locks commented 9 years ago

Did you download it from the website?

ishraq0 commented 9 years ago

Yes.

ishraq0 commented 9 years ago

screen shot 2015-04-06 at 10 57 40 pm See? Proof. Not messing about.

atg commented 9 years ago

Super cereal.

(huh that email address is old.)

atg commented 9 years ago

I can't reproduce this either. Maybe it only happens on mavericks?

ishraq0 commented 9 years ago

Yeah, I am using Mavericks (10.9.5).

sammoore commented 9 years ago

I have Yosemite 10.10.3 & Chocolat 3.1.4 and can confirm this worked for me too. :worried:

screen shot 2015-06-03 at 11 16 30 pm 1

ishraq0 commented 9 years ago

Ah, finally! Someone to back me up on this. :+1:

sammoore commented 9 years ago

So I opened up Chocolat today and it locked me out; worse than that, I can't actually pay for it or do anything. Help? @fileability

I'm assuming @Illumynous did not face this problem, although I'm sure he can provide some input.

FWIW I bought a serial number for Chocolat like 3 or 4 years ago, and I just can't find it, and I've tried going on IRC several times and no one was active, and I've just always put it off (when TextMate was open-sourced along with Sublime Text coming out it gave me even more reason to put it off). I was just going to pay the full price though. I seriously need the hooks into auto-completion and documentation though!

ishraq0 commented 9 years ago

@sammoore Locked you out? Nah, didn't face that problem.

sammoore commented 9 years ago

Any word @fileability @chocolat ? Please let me pay for the app, I can no longer use it on my system and was just checking to see if this bug was real, which is the only reason why I would confirm it to you on GH Issues...

chocolat commented 9 years ago

@sammoore Hm, I'm a bit confused, what do you mean it's locked you out?

chocolat commented 9 years ago

As for the actual issue, while I'm not in any hurry to drop mavericks support, there's not that many people using it either. So I guess this is "interesting".

chocolat commented 9 years ago

@sammoore btw you can clear your registration by doing

$ # (quit chocolat first) $ defaults delete com.chocolatapp.Chocolat Activation

sammoore commented 9 years ago

@chocolat thank you so much for getting back to me! I can actually be productive now :coffee: :heart_eyes:

So I narrowed down the test case on how I got locked out, and even got a screenshot; it appears that the app thinks I'm running version 2 or something, or at the very least wants me to pay. To the end user, once you get to this stage, there's no way to change the serial key back without deleting that defaults.

Anyway, I could easily reproduce the lock-out; I can register via 15 empty spaces again, and upon rebooting and relaunching Chocolat, I see this window:

screen shot 2015-06-11 at 10 58 35 pm

It says to upgrade inside of Chocolat, but I already am :/ So thank you for giving me the fix, I purchased a license earlier today. If there's anyway I can help I'd be glad to, but I imagine if there's no other case where this lock-out occurs you may as well just prevent a serial key of just white-space. EDIT to clear it up, the options in the Menu are all disabled, so there's really nothing I can do; does it think I'm on Mavericks?